node-soap icon indicating copy to clipboard operation
node-soap copied to clipboard

WSSecurity Protocol with user/pass token element.

Open OlafurTorfi opened this issue 2 years ago • 5 comments

Hi

I pulled the package, and the tests were failing out of the box. So I just made some minor hacks to get the tests running.

Then I updated all but two of the packages (the major versions of formidable and strip-bom required more changes than fixing the import and adding some types. So I left those.

Then I added a new security protocol, WSSecurityCertWithToken. Is basically the same as WSSecurityCert, except that it takes in a username and password as well. Which we need here in iceland.

I have used this WSSecurityCertWithToken protocol implementation in production, and can confirm that it works.

OlafurTorfi avatar May 20 '22 12:05 OlafurTorfi

please fix the build

jsdevel avatar May 30 '22 16:05 jsdevel

@OlafurTorfi please fix the build

jsdevel avatar Jun 06 '22 19:06 jsdevel

The merge conflict has been resolved.

OlafurTorfi avatar Jun 09 '22 09:06 OlafurTorfi

@OlafurTorfi please fix the build

jsdevel avatar Jun 15 '22 19:06 jsdevel

I resolved conflict and seemed like it works. Wondering if @jsdevel wants to review it again? I personally don't see any problem merging it.

w666 avatar May 01 '24 09:05 w666

No objections on this PR, tests passed, merging.

w666 avatar May 14 '24 06:05 w666