w0xlt

Make error message layout consistent

5

Currently, the error message for invalid change address is displayed on the right while in the "Pay to" and "Address" fields do not show the error message, as commented in...

Unit tests incompatible with `qt5ct` or `qt5-style-plugins`

2

I installed `qt5ct` and `qt5-style-plugins` to change the Bitcoin Core theme (master branch) on Ubuntu 21.10. If I change Ubuntu to dark mode, Bitcoin Core does not change. So most...

Add translatable address error message

3

This PR is an alternative to https://github.com/bitcoin-core/gui/pull/533 that addresses https://github.com/bitcoin-core/gui/pull/533#pullrequestreview-860261164 . While this PR no longer provides a detailed error message, it still brings some UI improvements: . Improve user...

Convert `secp256k1_xonly_pubkey` to `secp256k1_pubkey`

2

Is there a way to convert a `secp256k1_xonly_pubkey` into a `secp256k1_pubkey` ? Reason: Extract `secp256k1_xonly_pubkey` from a P2TR address and use it as parameter to `secp256k1_ecdh()`. Edit: Seem related. https://github.com/bitcoin-core/secp256k1/pull/994...

Error right after `make -j$(nproc) check VALGRIND=0`

3

I am following the [INSTALL.md](https://github.com/ElementsProject/lightning/blob/62bfed9a8df8731be44ba4e86afb08a5d28a4442/doc/INSTALL.md) and getting the error below right after `make -j$(nproc) check VALGRIND=0`. I am building from the master branch. OS: Ubuntu 21.10 ```bash ... rm -f...

Switch to the selected wallet after loading

3

Currently, the user loads a wallet and the screen does not switch to the selected wallet after loading (File -> Open Wallet -> wallet name). This PR changes that by...

p2p: Replace RecursiveMutex `m_tx_inventory_mutex` with Mutex and rename it

12

This PR is related to #19303 and gets rid of the `RecursiveMutex m_tx_inventory_mutex` and also adds `AssertLockNotHeld` macros combined with `LOCKS_EXCLUDED` thread safety annotations to avoid recursive locking.

wallet: Replace `GetBalance()` logic with `AvailableCoins()`

2

This PR proposes a solution for https://github.com/bitcoin/bitcoin/issues/26500 by changing the `AvailableCoins()` function to calculate values by status (`TRUSTED`, `UNTRUSTED_PENDING` and `IMMATURE`) and ownership (`MINE`, `WATCH_ONLY`), eliminating the `GetBalance()` logic. The...

Remove `SECP256K1_WARN_UNUSED_RESULT` from `secp256k1_keypair_*` functions

3

Why do `secp256k1_keypair_*` functions have `SECP256K1_WARN_UNUSED_RESULT` if they always return 1 ? The only exception is `secp256k1_keypair_create`.

export: Add `tr()` descriptor as compatible with Bitcoin Core

2

I tried to export a Taproot wallet and got the error `The descriptor is not compatible with Bitcoin Core`. It looks like this part of the code has not yet...