gui icon indicating copy to clipboard operation
gui copied to clipboard

Published 20 hours ago • verified publisher icon bitcoin-core

Make error message layout consistent

Open w0xlt opened this issue 3 years ago • 5 comments

Currently, the error message for invalid change address is displayed on the right while in the "Pay to" and "Address" fields do not show the error message, as commented in https://github.com/bitcoin-core/gui/pull/553#issuecomment-1047306976.

This PR makes the address error feedback consistent across all fields.

Supersede https://github.com/bitcoin-core/gui/pull/534

master
master_pay_to
master_addr_edit
PR
pr_pay_to
pr_addr_edit

w0xlt avatar Feb 26 '22 04:02 w0xlt

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #612 (refactor: Drop unused QFrames in SendCoinsEntry by hebasto)
  • #534 (Add translatable address error message by w0xlt)
  • #533 (Add more detailed address error message by w0xlt)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot avatar Feb 26 '22 21:02 DrahtBot

I assume in this figure there is a static placeholder for the red label (normally empty):

I assume that's regular P2WPKH invoice address you are showing.

Would mean the destination address box be shorter. So what happens if destination address is a longer P2WSH address? Would it then clip while with the current code it would not?

katesalazar avatar Feb 26 '22 22:02 katesalazar

Concept ACK

RandyMcMillan avatar May 15 '22 17:05 RandyMcMillan

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

DrahtBot avatar Jun 21 '22 10:06 DrahtBot

tACK commit 9d75184fe7d915e05ac01d50cec90881594ef19a

Tested all address types in the 'Pay To', 'Custom Change Address', and 'New Send Address' fields.

Just noting that it says "Warning: Invalid Bitcoin address" immediately, but only highlights red when you click out of the text box. I don't know if I have a preference there. But I like the change.

I get this message when opening:

QVariant::load: unknown user type with name BitcoinUnits::Unit.

Rspigler avatar Aug 01 '22 18:08 Rspigler

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

DrahtBot avatar Oct 31 '22 10:10 DrahtBot