gui icon indicating copy to clipboard operation
gui copied to clipboard

Published 20 hours ago • verified publisher icon bitcoin-core

Add translatable address error message

Open w0xlt opened this issue 3 years ago • 3 comments

This PR is an alternative to https://github.com/bitcoin-core/gui/pull/533 that addresses https://github.com/bitcoin-core/gui/pull/533#pullrequestreview-860261164 .

While this PR no longer provides a detailed error message, it still brings some UI improvements:

. Improve user experience by showing an error message instead of just changing the color of QLineEdit . Currently, when an invalid address is entered in custom change address, an error message is displayed. But the same does not happen in the Pay To field or when adding a new address in the address manager. This PR standardizes error handling for all address fields. . The message added in this PR is the same as used in the custom change address, which is already translated into several languages.

PR
invalid_new_address
invalid_pay_to

w0xlt avatar Jan 23 '22 08:01 w0xlt

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #612 (refactor: Drop unused QFrames in SendCoinsEntry by hebasto)
  • #560 (Make error message layout consistent by w0xlt)
  • #533 (Add more detailed address error message by w0xlt)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot avatar Jan 23 '22 08:01 DrahtBot

A constant message seems as useless as the red background colour. Concept NACK

luke-jr avatar Jan 31 '22 04:01 luke-jr

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

DrahtBot avatar Jun 21 '22 10:06 DrahtBot

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

DrahtBot avatar Oct 31 '22 10:10 DrahtBot