William Jones

@JuliaKukulies I believe the change in the results is due to a bug I fixed in the old version: because the minimum spanning tree was applied before the time filter...

Naming suggestion: "cluster" for a collection of features at one time step

> Okay, this is now ready for review in my opinion. This PR contains changes from #380. > > I'd like feedback (and testing) everywhere, but in particular, I'd like...

> > > Okay, this is now ready for review in my opinion. This PR contains changes from #380. > > > I'd like feedback (and testing) everywhere, but in...

Could this be solved using [DataArray.swap_dims](https://docs.xarray.dev/en/latest/generated/xarray.DataArray.swap_dims.html)?: ``` variable_da = variable_da.swap_dims({"time":"frame", "south_north":"hdim_1", "west_east":"hdim_2"}) variable_da.interp( coords=dict( frame=xr.DataArray(Features["frame"].values, dims="feature"), hdim_1=xr.DataArray(Features["hdim_1"].values, dims="feature"), hdim_2=xr.DataArray(Features["hdim_2"].values, dims="feature"), ) ) ``` Suggestion was found via this still open...

I have started my review on this, along with #380 , but I think it would be good to discuss whether we want to do refactoring during the switch to...

I think I've noticed this before, and the issue is to do with calculating the timesteps from `cftime` format. I think that in the current versions of tobac the time...

Also happy for this to be merged :)

Does this only happen with PBCs or with any case? We should probably check and raise an exception if all points are above all thresholds in any case