William Jones
William Jones
Hi Eric, I'm definitely supportive of this. My thoughts on your two points, in reverse order: 2. The creation of a method to consolidate the multiple "v1.0" data outputs into...
Transferring detected features and segmentations across different grids is definitely a feature on the radar for tobac v2.0. This sounds like a subset of that situation, where it's only applied...
Here's a quick mock-up of what I'm thinking: The idea is that it's much easier to map a geopandas/shapely boundary formed from a set of points from one coordinate system...
Just updated this to merging into v2.0-dev branch, which seems to have cleared up all the conflicts. I'll review and merge once I get the chance, but it all looks...
Overall this looks good, but I have a couple of thoughts/requests: 1. Like Sean, I think it would be better to have this as an optional parameter to calculate, rather...
Chunking is definitely the best solution for this. With the current methods implemented in tobac chunking by time for the feature detection and segmentation poses no problems. However, as you...
Just fixed the same problem in some of my own code, and would agree that setting missing/invalid values to -1 is an improvement over NaN. We could use a larger...
I've looked into using `scipy.ndimage.label` for this before, and although I don't think we can use it directly (as it would overwrite the segmentation step), we can use a similar...
I've started work on adding overlap tracking in https://github.com/w-k-jones/tobac/tree/overlap_tracking, with a basic working version. There are still a number of features that need adding/improving, but I'll open a draft pull...
Keeping as draft until #368 is merged as this contains the same commits