vyzo

Results 615 comments of vyzo
trafficstars

CI failures - seems like a faulty commit.

@ppopth let's reenable the Fuzz test, it seems it is fine: see #574

running the CI, will merge once it greens.

> should I squash the fix-up commits? no need, I will squash merge anyway

There are more functions in the Peerstore interface. Also, don't expose `SET_PROTOCOLS`, this is used internally by identify I think.

There are more interfaces it implements. And again, we don't want to expose the `SET_PROTOCOLS` method, as it is pointless to set it unless the peer advertises a protocol --...

> It's not implemented and I don't intend to add it, are you referring to ADD_PROTOCOLS? Yes, both are not to be used willy nilly. > Is SUPPORTS_PROTOCOLS even necessary...

Now this is probably too much; we need to be a little more selective for utility here :)

That looks better. @bigs opinions?