vyzo
vyzo
which shouldn't be because it is also using the default transports.
This is because there needs to be some confidence on the observations in autonat; you need to connect to enough peers to verify that (I think it's 3 or 4),...
Yeah, connection notifications are probably very useful. We can add a relevant interface, although it is a little complex to implement.
ok, can you rebase on master?
seems like we have some flaky tests :(
@ppopth can you look at the go-check CI failure? Looks like the linter is complaining about some things.
done
I think these are just flaky tests, i dont think your pr is breaking them.
Regarding the test failures: - TestGossipsubConnTagMessageDeliveries this seems consistently flaky; let's add a t.Skip and open follow up issue to fix it. - FuzzAppendOrMergeRPC @ppopth this might need to be...
thats a flake then. Ok, disable and open follow up issue!