Vincent Weevers
Vincent Weevers
Might be caused by the combination with `passive` (just because that's not a use case I anticipated and may have some unintended side effect) though at quick glance I don't...
In that case, yes, looks like a bug. I will need to debug, can't say when I'll have time.
This is an expected behavior (also in `leveldown`) at least from the LevelDB side. It creates the directory and takes a lock before checking if the "database" exists: https://github.com/Level/classic-level/blob/15eb2893086ff52f6ce5b2b79a21ca6340b966fc/deps/leveldb/leveldb-1.20/db/db_impl.cc#L280-L302 I...
> Or said differently, I would expect "createIfMissing=false" do not alter the file system, unless there is already a created database right there. That is a fair expectation, but not...
> but if the LOCK file doesnt exist, then there is no valid database, right? I don't have a clear answer to that. LevelDB itself has no reason to delete...
We've had this option for more than 10 years, long before I joined, and personally I've never needed it. But I would guess it's for initialization, when combined with `errorIfExists`:...
I guess now we have to add `cmake-js` to `prebuildify`? Like https://github.com/prebuild/prebuildify/pull/7
A rough description of tasks (feel free to edit): - Diff our `deps/leveldb/leveldb-1.20` against upstream 1.20, generate `.patch` files (#459) - Update to 1.22 - Possibly get rid of `deps/leveldb/port-libuv`,...
@rvagg I have no experience as a user of `cmake-js`, but as a maintainer of `prebuild` which integrates with `cmake-js`, I know `cmake-js` is unable to find MSVS since 5.2.0...
Common Changelog does not cover translations (yet). Personally I rarely see them in the wild so I don't know: - If there are enough examples out there to find patterns...