Vincent Weevers

Results 327 comments of Vincent Weevers

We can change the `AbstractLevel` to `AbstractLevel` here: https://github.com/Level/many-level/blob/a56d72df52c3f9d301a0885705c5dc223576ef31/index.d.ts#L74 My intent was probably to enforce that the given database supports Buffer, but that's not really a job for TypeScript and...

> That does seem to work Great! > if it's not desired to be typed that way, the documentation could mention to do `new Level` or `new Level` as a...

Looks like a bug in Node.js: https://github.com/nodejs/node/blob/10c6596f6d7abf7451112e767f8277fcd276d796/lib/internal/streams/writable.js#L879

https://github.com/nodejs/node/pull/52110

Both the pino test and airtap override `console.error` ([here](https://github.com/pinojs/pino/blob/297b900b9612a9feadc8e5f6e64601d6683749a8/test/browser.test.js#L655) and [here](https://github.com/airtap/airtap/blob/034a6cf5c0f0014c94ac7f83b19fee69eda218e4/client/index.js#L43)). Airtap wraps and calls the original function so that should not be a problem. Pino only intercepts a single...

https://github.com/airtap/airtap/blob/034a6cf5c0f0014c94ac7f83b19fee69eda218e4/client/index.js#L43

https://github.com/prebuild/prebuildify-cross/pull/24

In the case of `node-gyp-build` (or the `node-gyp-build-optional-packages` fork that `lmdb` employs) it is safe to use `--ignore-scripts` if a prebuilt binary is available for the platform that you're running...

IMO use of `--no-bin-links` is at your own risk, because it's an essential feature for npm scripts. There is no alternative that has the same level of convenience.

My view is that people who are interested in an older release line, will have no problems finding that branch and the relevant changelog. But other people (the majority?) who...