Vincent Weevers
Vincent Weevers
The maximum value of a byte is 255. Buffer is a Uint8Array (rather than a Uint8ClampedArray), so values get wrapped. ``` $ node > new Uint8Array([255, 256, 257]) Uint8Array(3) [...
> Yes. Although it oddly wraps at 100 A hexadecimal `100`. Perhaps that's where the confusion comes from: `console.log(buffer)` prints a hexadecimal representation of the bytes. Here's an easy way...
> and warns about the invalid example I should have given a more specific invalid example: ```md | foo | a long column | bar | | --- | -------------...
> Isn’t this closed to [`table-pipe-alignment`](https://github.com/remarkjs/remark-lint/tree/master/packages/remark-lint-table-pipe-alignment)? Its readme states: > You can pass your own stringLength function to customize how cells are aligned. In that case, this rule must be...
> ...right? So this rule/option/feature is only about the alignment row Right. I didn't know that the "alignment row" had a name, cool. Does it warrant a separate plugin?
> Maybe it’s time to revisit how the alignment row is created when not aligning cells. Ideally remark would be able to create this table style. FWIW when I discovered...
> The `paddedTable` option in remark is about `|a` and `b|` (when false) and `| a` and `b |` (when true). It does this for the alignment row as well....
Sounds good! There's a secondary issue: the `'compact'` option of `remark-lint-table-cell-padding` (and `remark-lint-table-pipe-alignment` if it were to follow this behavior) matches `{ spacedTable: false, paddedTable: false }`. How about also...
> It's hard to put into words why this way feels better than dot notation for these certain cases, but it does. In the case of `headers`, it feels better...
> We should probably do the same for tags in HTML files too, while we're at it. One requirement for this is that generated HTML (like a code coverage report)...