Vincent Weevers

Results 327 comments of Vincent Weevers

@aminya This issue is slightly different from the one you had, so keeping it open.

@aminya The two issues are both related to `__dirname`, but not the same. Your issue was about using a bundler in your native addon, which changed the location of the...

I've found it useful many times. Would it help to tweak the message?

Could mean that `node-gyp-build` fails on the [`require()` test](https://github.com/prebuild/node-gyp-build/blob/0078d7884dfeb0e708477b3e20bfc4f520c1e2f8/build-test.js#L19), which loads the addon at install time as a smoke test. To check that, run `npm install @parcel/watcher --ignore-scripts` (to skip...

@ralphtheninja https://github.com/sinonjs/lolex might be useful for the tests here

Good news: it looks like the recent changes in `leveldown` (deferring close with pending put or iterator, or something else) decreases the likelihood of the race issue. If I change...

Correction, `memdown` failed tests because its iterator yields a different key type than `leveldown`. Trying to figure out why - before further investigating the race issue because there could be...

Okay. The "problem" with `memdown` is that, when wrapped with `encoding-down` and the `utf8` encoding and you `put()` a Buffer, then you'll always get back a Buffer because `memdown` only...

Yes, we can. This fits well in https://github.com/Level/community/issues/98. But: we're behind on maintaining `level-ttl`. It has race issues that need solving first.

That's a `parseInt()` behavior, unrelated to Buffer: `parseInt(0x61, 16) === 0x97`.