Vlad

Results 8 comments of Vlad

Hi @jscottbranson I'm currently looking at this request and changing the line in the code to be consistent with current default max_page_count doesn't seem to be an issue. My main...

Hi @jscottbranson I've given it another thought in the morning. I have a couple of assumptions and questions: Rippled connects to your db file and actually fails as expected. Your...

> > Test Plan Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47 > > Can you pls add a command line option to...

> > > > Test Plan Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47 > > > > > > > > >...

> Almost good to go. I'm wondering, in a possible follow-up PR, whether we can make it a lot harder to forget to close the test ledger by making it...

do you still experience this with newer 2.5.x or 2.6.x versions?

> @vvysokikh1 can you please address the review comments & resolve the conflicts? This change would be perfect for the next release. Comments addressed

Do you still experience something similar with latest 2.5.x or 2.6.x versions?