Valentin Volkl

Results 9 comments of Valentin Volkl

Thanks for the comments!

Thanks! The LCG releases still use 2.10.2, can you add that version as well? (If it builds correctly)

Thanks @wdconinc - I think for completeness this is nice to have, even if some bitrot is to be expected and nanocernlib seems a great alternative where possible. I tried...

Thanks for reporting this issue in detail. As far as I am aware, no one has tried to run the ROOT test suite in spack, so you may encounter more...

Or add https://github.com/root-project/root/pull/14192/files.patch as a patch.

Indeed, this would be great to have! For completeness, I also link to a relevant section of the docs: https://github.com/HSF/phoenix/blob/master/guides/developers/event-data-loader.md

This will be very nice to have, thanks! I'll take a closer look this week. For the naming, I'd suggest "DataSource" instead of "Source". This should also eventually move to...

Hmmm, I'd wait with merging this, it should be tested also with `spack install --test=root fccanalysis`

Added my fix for building on macOS, which can at least be used as a patch in spack . @kjvbrt up to you how you want to organise the headers...