FCCAnalyses icon indicating copy to clipboard operation
FCCAnalyses copied to clipboard
verified publisher icon HEP-FCC

Cyclical link dependencies FastJet addon <-> FccAnalyses?

Open vvolkl opened this issue 1 year ago • 2 comments

The FastJet addon uses symbols from JetClusteringUtils.cc (here for example) and should actually link to the FccAnalyses target where JetClusteringUtils.cc is built. But the FccAnalyses target links against the FastJet addon here.

Not sure why the linker does not complain ( it does with apple-clang 16 on macos, where I noticed this). Maybe JetClustering.cc should be moved back to analyzers/dataframe?

vvolkl avatar Oct 28 '24 18:10 vvolkl

I have also found this issue. This should indeed by fixed if we want to compile on MacOS. The options are either to move back JetClusteringUtils.cc to analyzers/dataframe or create an additional library with jet clustering utilities that could be linked in the FastJet plugin.

jmcarcell avatar Jan 10 '25 20:01 jmcarcell

Added my fix for building on macOS, which can at least be used as a patch in spack . @kjvbrt up to you how you want to organise the headers in the longer term.

vvolkl avatar Jan 14 '25 09:01 vvolkl