vulcandth
vulcandth
@Rangi42 Sorry, hate to ping you; but whenever you have time, no rush! I'd like for your opinion on this as well before I go through the great effort of...
So I've been slowly working through this PR in my spare time... and I'm starting to worry that it could become rather difficult to review in a single PR. Here...
> One time I added an `object_event` with a text ID higher than the `bg_event` ones, and it broke a sign: [Rangi42/redstarbluestar#3](https://github.com/Rangi42/redstarbluestar/issues/3) I had to put object events first, then...
From a cursory look at the address. I don't believe `wd732` to be specific to Cycling Road. It appears to handle setting warp flags for all warps. It just also...
> The code which preserves that byte is in fact in the production build and not only in the debug build of the games. Hence, why my suggested bug fix...
It looks like the start of the Bug Documentation for this has been created ~~[here.](https://github.com/pret/pokered/wiki/Fix-the-oversight-that-doesn't-clear-WRAM-address-'wd372'-after-starting-a-new-game-at-the-Cycling-Road)~~ This will eventually be included in pokered's future `docs/bugs_and_glitches.md` (https://github.com/pret/pokered/issues/258). This wram address and the...
When I get some time; i'll see about starting this. I'll create a `docs/bugs_and_glitches.md` formatted similarly to pokecrystal's. I'll add a bug fix or two... and create a PR to...
> It can start as a wiki page for easy contribution; I thought someone had already made one in the pokered wiki, but apparently not. Yeah; that might be a...
@Rangi42 Your suggested changes causes a conflict with the constants being created in my PR: ``` error: maps.asm(255) -> data/maps/objects/LavenderTown.asm(16) -> macros/scripts/maps.asm::bg_event(69): Expected constant expression: 'TEXT_LAVENDERTOWN_POKECENTER_SIGN' is not constant at...
That worked and is functional with the changes in my new PR (Tested by purposely changing around some TEXT constants). I'm going to incorporate this into my PR and will...