vue icon indicating copy to clipboard operation
vue copied to clipboard

Fix #9847 Add shouldRenderAsyncScripts option

Open jeanphilippeds opened this issue 4 years ago • 23 comments

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [x] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

jeanphilippeds avatar Nov 04 '19 14:11 jeanphilippeds

@yyx990803 Please look to this at affection :pray: :heart_eyes:

AGPDev avatar Nov 09 '19 18:11 AGPDev

Hi guys, this is super important for performance. Do we have any ETA? Thanks :)

fibigerg avatar Feb 13 '20 15:02 fibigerg

Would be really great to see this one pushed through, this feature is very important to reduce Javascript load in front end, which will be a big boost to SEO

paulsharratt0 avatar Feb 17 '20 05:02 paulsharratt0

Any update on when this feature will be available? We are using lazy hydration it will be a huge plus to not load the not needed bundles at first.

Moncef12 avatar Feb 25 '20 11:02 Moncef12

+1 for this - would speed out Vue/Nuxt applications greatly. Any updates on when somebody pushes the merge button?

simplenotezy avatar Mar 08 '20 22:03 simplenotezy

C'mon guys @jeanphilippeds did all the hard work on this one, it shouldn't even be that hard a merge as it's an optional boolean, can we get this in soon?

paulsharratt0 avatar Mar 08 '20 22:03 paulsharratt0

Can we merge this please? <3

Tantawi avatar Mar 21 '20 20:03 Tantawi

WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS!

asennoussi avatar Mar 22 '20 03:03 asennoussi

PLEASE <3

fibigerg avatar Apr 23 '20 11:04 fibigerg

please

NinthAutumn avatar Apr 27 '20 23:04 NinthAutumn

yeah this would allow great performance improvements!

dotBits avatar May 15 '20 08:05 dotBits

For everyone who is using nuxt, here is a workaround: https://github.com/vuejs/vue/issues/9847#issuecomment-626154095

simllll avatar May 15 '20 08:05 simllll

@yyx990803 @posva @Akryum @Kingwl @LinusBorg Can we merge it please ? 🙏

@jeanphilippeds Did a very usefull work here !

quentinlagache avatar Jun 04 '20 13:06 quentinlagache

I wonder what's keeping us from merging this with latest release? How can I help?

simplenotezy avatar Jun 04 '20 21:06 simplenotezy

Guys, any news? how can we help? Sice google Web Vitals now scan more for unused code, this would help greatly.

Darwex avatar Jun 09 '20 22:06 Darwex

We currently focus all our efforts on bringing Vue 3 and its supor libs into RC stage.

Please understand that we currently have less bandwidth for Vue 2, and improvements such as this are currenty not a the very top of the list.

We will ge back to Vue 2 and do a round of bug fixes and improvements as soon as our bandwidth allows.

LinusBorg avatar Jun 10 '20 07:06 LinusBorg

@LinusBorg Fully understandable. Can't wait for vue 3. However, is this fix expected to hit Vue 3 as well?

simplenotezy avatar Jun 10 '20 08:06 simplenotezy

Man, this is killing me waiting for this!

@jeanphilippeds, well done! Gutted it still hasn't made it's way in 7 months later

spacedawwwg avatar Jun 16 '20 01:06 spacedawwwg

Hi, @LinusBorg, any progress on this? We are still waiting. It is even harder to get nice score after last PageSpeed Insights update.

fibigerg avatar Oct 30 '20 20:10 fibigerg

Hi guys, there are still projects on Vue 2, can someone merge this, please? It really became a problem with new versions of Google Lighthouse.

fibigerg avatar Jul 30 '21 18:07 fibigerg

can we merge this please?

alexander-schneider avatar Feb 21 '22 11:02 alexander-schneider

How can I help getting this merged?

coffeeneed avatar Oct 01 '22 10:10 coffeeneed

Is there any chance that this RP will be merged, as it has been over 3 years now.

lateek35 avatar Apr 26 '23 09:04 lateek35