vue icon indicating copy to clipboard operation
vue copied to clipboard

fix(events): rule of calling binded event handler (close #11014)

Open rx-837 opened this issue 4 years ago • 4 comments

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [x] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The checkbox 'Refactor' is checked because of rules ordering was changed. The primary rule should have bigger priority than crutches.

rx-837 avatar Jan 18 '20 22:01 rx-837

The fix looks good. Would be nice to have this merged 👍 !

joaomlemos avatar Feb 14 '20 00:02 joaomlemos

:+1:

jo4santos avatar Feb 14 '20 00:02 jo4santos

Have tested this fix, can confirm that it fixes our issue. Is there a chance of getting this merged so we don't need to have a patched version of Vue?

toshi38 avatar Oct 22 '20 09:10 toshi38

is there any update on this? we suffer the same problem as this.

s-tokutake avatar Nov 21 '21 04:11 s-tokutake