vue icon indicating copy to clipboard operation
vue copied to clipboard

fix(svg): apply every namespace in slot when call applyNS

Open zhangzhonghe opened this issue 4 years ago • 6 comments

Fix #11315

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [x] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

zhangzhonghe avatar Apr 26 '20 13:04 zhangzhonghe

Any idea when we get this? Really need it.

cartok avatar Feb 19 '21 07:02 cartok

Slots do not render in foreignObjects if the foreignObject is not in the template of the same component that has the root svg element of the svg. Means you can't split svg into components properly.

cartok avatar Feb 19 '21 07:02 cartok

What can we do to get this merged in? I really need this fix

patrick-beep avatar May 08 '21 00:05 patrick-beep

Is this going to get merged in?

msetegn avatar Nov 12 '22 02:11 msetegn

Have been waiting for this fix for a long time now.

staffanpalopaa avatar Jan 01 '23 12:01 staffanpalopaa

I just rebased it on the latest code. I don't know why it makes this big!

zhangzhonghe avatar Jan 02 '23 07:01 zhangzhonghe

See #13008

zhangzhonghe avatar Apr 24 '23 12:04 zhangzhonghe