Vuk

Results 11 comments of Vuk

@maxwondercorn , @rwwagner90. Do you have a plan or currently work in progress to convert this to glimmer? I would like to help in the effort to update this addon....

I created a PR with the fix if someone can just run the workflow and merge it https://github.com/adopted-ember-addons/ember-light-table/pull/824

@RathiRohit I think this might be fixed with latest release `2.1.1`, can you try it?

Any updates on this?

@RobbieTheWagner I can try :D, The code seems clear to me, but haven't tried to run this at all. I will make a fork an see how it goes, but...

@RobbieTheWagner tbh I haven't had the time to tackle this at all right now... Not sure when I will get to it :/ If you are interested in taking a...

@SergeAstapov on first glance, I think it will require some extra work most likely, since probably lines, columns will be off

@andrewtimberlake actually I think this is not related to Glint nor Ember, this is just a problem in Typescript in general. You can see https://github.com/microsoft/TypeScript/issues/28357#issuecomment-748550734 for a possible solution

After further inspection this problem only seems to happen when passing in a component name as a `string` to `{{component}}` helper, if we pass in a component `class` it works...

Also I'd recommend rewritting tests to TS to prevent such type regressions in the future