ember-light-table icon indicating copy to clipboard operation
ember-light-table copied to clipboard

Addon native classes

Open maxwondercorn opened this issue 2 years ago • 4 comments

Decorators (tagName, classNamesBindings, etc) remain because outer HTML breaks demo app/tests due to the extra divs. Using @tagName('') to remove them causes other errors.

I believe everything needs to be converted to glimmer to finish the cleanup.

addObserver, removeObserver are used instead of the @observes decorator because it's not glimmer compatible

maxwondercorn avatar Aug 08 '22 02:08 maxwondercorn

@maxwondercorn , @rwwagner90. Do you have a plan or currently work in progress to convert this to glimmer? I would like to help in the effort to update this addon. Not sure if you want to convert everything in one go or do you think it is a better idea to just create incremental PRs upgrading parts until we have covered everything?

vstefanovic97 avatar Aug 12 '22 09:08 vstefanovic97

@vstefanovic97 we would love the help! I think either way is fine.

RobbieTheWagner avatar Aug 16 '22 16:08 RobbieTheWagner

I think we need to take another look at what should be @tracked and make sure all the things are updating as we expect. Alternatively, we could put back some of the old computeds.

Added computed back. Most properties are on the class which still need to be converted to native classes

maxwondercorn avatar Sep 02 '22 22:09 maxwondercorn