Stefan Zabka

Results 206 comments of Stefan Zabka

I'm in favour of aligning with the official and publicly documented schema instead of the Firefox internal one. We should make sure that we are aligned with these names by...

Hey, I initially thought this would just be about copying one line over from the faust-selenium repo and removing some localized piece of code. But it turns out our timeout...

From our exploration we found two options: 1. Remove the JSON mapper in `source.json` so the already valid JSON generated in the [`SourceTask`](https://github.com/zeebe-io/kafka-connect-zeebe/blob/7a859a8151af738eeeaea87edcdd9d24bb5343b1/src/main/java/io/zeebe/kafka/connect/source/ZeebeSourceTask.java#L172) doesn't get scrambled 2. Define a new...

Yes, you need to remove it from the parquet_schema but also from [the S3 Aggregator](https://github.com/mozilla/OpenWPM/blob/master/automation/DataAggregator/S3Aggregator.py)

This feature is not yet available to us, because it's currently only in the alpha branches of the 4.0 version of selenium. We are currently on version 3.141

I can confirm that `collection_fingerprinting` is still the default. https://github.com/openwpm/OpenWPM/blob/abf10d745a42f6781a1b6116976a613900f73977/openwpm/config.py#L83-L85 But I get how the docs are confusing in this aspect.

The docs should be updated to state, that the js_instrument_settings, that were the default prior to v0.11.0 have been grouped into a collection called `collection_fingerprinting` and that this collection is...

@symonk Sorry to ping you on this but can you run the tests again please

> Does Python Selenium manage logging this way elsewhere in the code or is it only geckodriver logs? I found the [`webkitgtk/service.py`](https://github.com/SeleniumHQ/selenium/blob/316f9738a8e2079265a0691954ca8847e68c598d/py/selenium/webdriver/webkitgtk/service.py#L39) and [`wpewebkit/service.py`](https://github.com/SeleniumHQ/selenium/blob/316f9738a8e2079265a0691954ca8847e68c598d/py/selenium/webdriver/wpewebkit/service.py#L39) have a similar pattern, but they...

Looks great! Is there any way I can contribute to #12103 or #12030? Or should I just wait?