OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

Use set_page_load_timeout

Open vringar opened this issue 6 years ago • 3 comments

This issue can only be tackled one we have moved the iteration of the CommandSequence and the execution of the individual commands into a single thread. Once this has happened I'll come back to this. Reference implementation can we found here

vringar avatar Feb 14 '20 18:02 vringar

Hi @vringar, I'm interested in working on this. Could you please provide some more background? What is the current timeout implementation and why is the proposed implementation less resource intensive?

boolean5 avatar Mar 16 '20 18:03 boolean5

Hey, I initially thought this would just be about copying one line over from the faust-selenium repo and removing some localized piece of code. But it turns out our timeout logic is spread over multiple files and threads and I don't feel comfortable calling this a good first issue anymore. I'm sorry for marking it as such and hope you find another issue to work on.

vringar avatar Mar 17 '20 11:03 vringar

That's ok, I'll find something else to work on for now and might get back to this later when I'm more familiar with the entire OpenWPM code base. Thanks for letting me know.

boolean5 avatar Mar 17 '20 11:03 boolean5