Marcin Ignac

Results 174 issues of Marcin Ignac

A correct viewport will be set if not provided but rendering to a texture but scissor is not. https://github.com/pex-gl/pex-context/blob/master/index.js#L533 ``` if (!cmd.viewport && cmd.pass && cmd.pass.opts.color) { let tex =...

Dispose https://github.com/pex-gl/pex-context/blob/master/index.js#L1181 Frame https://github.com/pex-gl/pex-context/blob/master/index.js#L948

type/feat

Submitting command with null or undefined `pass` will overwrite parent state and prevents inheriting framebuffer from state which will result in rendering to last used FBO instead of e.g. screen....

I'm getting this error in FF 67 ```Error: WebGL warning: texImage2D: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads.``` Caused by https://github.com/pex-gl/pex-context/blob/master/texture.js#L90 which should be moved to this if check...

type/fix

Using https://www.npmjs.com/package/webgl-debug would allow use to catch invalid enums and other gl errors.

type/feat

E.g. this should crash ``` ctx.pipeline({ blendSrcRGBFactor: ctx.SRC_ALPHA }) ``` as it should be ctx.BlendFactor.SrcAlpha

type/feat

If I compile invalid shader the render loop crashes and I'm not able to restart it no matter what. Chrome shows: ```javascript glDrawElements: Source and destination textures of the draw...

type/fix

Currently if you provide a mesh with invalid vertex layout e.g. aPosition attribute missing the `pex-context` will crash via failed `assert` . e.g. ``` assert.fail(`Can't set uniform "${name}" with a...

type/feat

In https://github.com/pex-gl/pex-context/blob/master/index.js#L695 we do ``` for (let i = 0; i < 16; i++) { state.activeAttributes[i] = null gl.disableVertexAttribArray(i) } ``` while https://kripken.github.io/emscripten-site/docs/optimizing/Optimizing-WebGL.html#avoid-redundant-calls explicitly says to avoid it

type/feat