Volker Mische
Volker Mische
> @vmx It's a good idea but I'd be careful with adding only `--release` flag. It disables a bunch of useful assertions and checks (e.g. overflow). Yes, one has to...
Also rebased on your branch.
I've rebased this PR and also adapted it to the fixed names.
I've changed the base to `feat/nv23`.
> 1. Who should we set the assignee to? In the past did the FilCrypto team the Rust side of things and then the Lotus team added the Go parts...
I should've added that in the past the Go side (Lotus team) owned the merging of things of the FFI, the FilCrypto team was just contributing to the Rust side...
A possible fix is at https://github.com/filecoin-project/filecoin-ffi/pull/424/.
This is even more difficult. We currently create universal binaries on MacOS for x86 and aarch64. We need to check if it also works to create x86 version on the...
I've fixed the original error, it was just about setting the `LIBRARY_PATH`. Though this should *not* be merged as building the universal binary on MacOS probably does *not* work yet.
This PR needs thorough review/testing by someone from the Lotus team. It should build the correct release artifacts, but I haven't really tested it. I'm neither that familiar with Lotus,...