Volker Mische

Results 341 comments of Volker Mische

As `libipld` is deprecated, I'm currently looking into repositories still using it. I then try to help with PRs. The concept of a `Block` doesn't exist in `ipld-core` (the replacement...

This sounds like something for Multihashes specifically. So it would be a Algorithm Key named something like `multihash`, right? Sorry if I state the obvious, I only had a quick...

To make things simpler, I propose reverting the `rust-toolchain.toml` file back to just a `rust-toolchain` file which contains the version only. This way CI can just `cat` file in order...

> * Use [benchmark.js](https://www.npmjs.com/package/benchmark) for execution/measurement Just FYI: people I trust making the right decisions are using https://github.com/tinylibs/tinybench for benchmarking, which according to them has less issues with async. So...

I've talked about this a bit with @mabels over Discord, here's the current outcome: - Bundling: I misunderstood the current bundling. I thought it's a bundle with all dependencies. That's...

@cryptonemo I cannot merge this PR as the CircleCI tests are marked as "required". Can you please change that setting.

@cryptonemo Thanks. Due to my new push (I removed commented out code), I need another approval.

I now also see an error locally on master. I'll have a look (it should be independent of this PR).

CI should be fixed now, could you please rebase your change?

The hashers were moved to `multihash-codetable`. There you can use the `Code` enum, from there you can e.g. [get an `u64` from the `Code`](https://docs.rs/multihash-codetable/0.1.4/multihash_codetable/enum.Code.html#impl-From%3CCode%3E-for-u64). Though, it's recommended that you implement...