filecoin-ffi icon indicating copy to clipboard operation
filecoin-ffi copied to clipboard
verified publisher icon filecoin-project

feat: add support for Non-interactive PoRep

Open vmx opened this issue 2 years ago • 6 comments

This commit adds support for ni-porep.

Also Rust >= 1.70 is needed due to the dependency on home v0.5.9 and fix the corresponding new Clippy warnings.

This is only the Rust side of things, the Go parts are missing.

vmx avatar Apr 23 '24 14:04 vmx

This needs to be rebased on top of https://github.com/filecoin-project/filecoin-ffi/pull/450, not master

cryptonemo avatar Apr 23 '24 15:04 cryptonemo

Also rebased on your branch.

vmx avatar Apr 23 '24 19:04 vmx

I've rebased this PR and also adapted it to the fixed names.

vmx avatar May 07 '24 12:05 vmx

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

cryptonemo avatar May 07 '24 12:05 cryptonemo

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

Yeah, that is correct. That branch was based off master today, so it should not cause any issues.

rjan90 avatar May 07 '24 12:05 rjan90

I've changed the base to feat/nv23.

vmx avatar May 07 '24 15:05 vmx

Just going through and looking at nv23-related open items. A few questions:

  1. Who should we set the assignee to?
  2. What is remaining?
  3. Who is expected to do the reviewing?
  4. Have we looked into the CI failures?

BigLep avatar Jun 11 '24 22:06 BigLep

  1. Who should we set the assignee to?

In the past did the FilCrypto team the Rust side of things and then the Lotus team added the Go parts and merged it.

2. What is remaining?

The Go parts which are done at https://github.com/filecoin-project/filecoin-ffi/pull/456

3. Who is expected to do the reviewing?

For the Rust side of things, Elliptic Research, for the Go side I'd guess FilOz.

4. Have we looked into the CI failures?

I've pushed a new commit which should get things green.

vmx avatar Jun 12 '24 13:06 vmx

I should've added that in the past the Go side (Lotus team) owned the merging of things of the FFI, the FilCrypto team was just contributing to the Rust side of things (@cryptonemo please correct me if I'm wrong).

vmx avatar Jun 12 '24 13:06 vmx

@vmx : thanks for the explanation on how the filecoin-ffi work has been traditionally handled. I expect some of that may need to be reevaluated or at least documented in light of groups like FilOz and Elliptic Research being separate companies now, but that can be thought through and handled later.

For now, given this just has the rust changes and Elliptic Research is the owner of those, I've assigned this issue to you. Please go ahead and merge when you have approval (✅ here) and all the rust changes are included. (It sounds like per Rod there is a small change to bring over.)

BigLep avatar Jun 13 '24 05:06 BigLep

I'm closing given superseded by https://github.com/filecoin-project/filecoin-ffi/pull/459

BigLep avatar Jun 13 '24 23:06 BigLep