Vicent Martí
Vicent Martí
@Fumesover has kindly written tests for the feature in https://github.com/planetscale/vtprotobuf/pull/83 -- this is now implemented.
Hey, sorry I've never gotten to this issue before. I think @GiedriusS has already figured this out on his own, but for those reading: the recommendation in the README _is_...
This works for us at [Vitess](https://github.com/vitessio/vitess/). We're very interested on having a scatter-gather kind of API, particularly for serialization. Just thumbs up overall. Anything I can do to help with...
@PapaCharlie: for Vitess, we happen to often work with very large packets coming from the MySQL binary protocol which we must make available through the distributed system via GRPC. Although...
This seems sensible to me! To be fair, there may be a sharp corner hidden here which is not obvious by looking at the API. My homeboy @frouioui is going...
> @harshit-gangal thanks! https://github.com/vitessio/website/pull/1696 adds this to the 3 x binaries that changed @timvaillancourt I don't think you need to update the website directly: you're supposed to add this to...
Thanks Tim! LGTM. I'm 99% sure the flags section in the website is auto-generated now. @frouioui will know for sure. Need +1 to merge @harshit-gangal
@arthurschreiber: can you apply https://github.com/vitessio/vitess/commit/996e652f421c290ea5a546603190e3a49ed74beb to this PR? It significantly reduces all allocations we perform and should make us faster than the previous code, while still being correct
Yeah, the current string is obviously unrelated to your PR, I just noticed that we were using `atomic.Value` which is a very rough (type unsafe) API that has been superseded...
I think the error in CI is related to the changes here, but looking at the test, it may just not be properly written/testing the right thing. Can you give...