Vicent Martí

Results 65 comments of Vicent Martí

@sorbits: I gave this some thought overnight and decided that maybe something ike https://github.com/vmg/textmate/commit/e0bf32ead9744cea44a48f88243c7315b6d7102b would be a better idea. Adding a separate flag means that we can fix grammars, e.g....

@sorbits: Personally, I believe the variables feature should be orthogonal to this. Adding a `variables` rule next to the `include` gives us some very fuzzy logic for variable scoping. Ideally,...

> So I've been thinking about this for a couple days, seems to me what triggers this issue is when a new context is created. In this case an embedded...

Yes, I believe that resetting the base should be a choice _when including a subgrammar_, and not really related to the block it's included in. And going back to @sorbits'...

> That way we only allow the one single thing you have suggested, namely to reset base, but we do it with syntax that allow us to do more in...

Hi @ericrenard! > I can provide a sample proto file and modifications made if needed. I would appreciate that. I've been playing around with potential ways to pool the maps...

@amaurym: the `ProtoMethods` API in the ProtoBuf message can only be used if, as you point out, we were to fork _all of `protoc-gen-go`_ and override the metadata generation for...

Yes, that's how we run the compilation in Vitess itself. Just use the `--go_vtproto_opt` CLI flag to enable specific options without having to modify the original `.proto` files. That will...

@steve-gray Vitess has been using that flag to generate our protos for a year now, and it's been working well for us. Here's a link to our Makefile: https://github.com/vitessio/vitess/blob/main/Makefile#L243-L253 You...

> How is this intended to work for the other way around though? Sadly, because of the way the GRPC APIs work, this cannot be made to work the other...