Veljko Lipovac

Workflow: Rebase docs on develop upon push to develop

4

The idea is to use simple console instructions in a workflow `.yml`-file to perform a standard git rebase by checking out the repo in a temporary directory and perform respective...

Anomaly in overload of `Ad_array.__rmul__`

9

Hei, I have tried to wrap my mind around what is happening here, but I have absolutely no clue ``` import numpy as np import porepy as pp import scipy.sparse...

## Idea - PRs to `develop` branch must **not** contain the directory `/porepy/docs/`. - PRs to `docs` branch must **only** contain changes in the directory `/porepy/docs/` to avoid asynchrony between...

Extending fluid concept to fit CF & Standard formulations

5

Closes #1240 Closes #1247 ## Proposed changes Reworking the concept of `model.fluid` to be a general fluid with phases and components, instead of just a data collection of constants. Breaking...

Unifying the fluid concept

3

With the introduction of `porepy.compositional`, PorePy allows the user to model general multi-component, multi-phase fluid mixtures, including singular cases of 1-component and/or 1-phase. The fluid in the PorePy models so...

CF Merger #3: Compositional Flow models

2

Draft PR for the next step in including the branch [pmgbergen/porepy/tree/composite-flow](https://github.com/pmgbergen/porepy/tree/composite-flow) This PR contains the compositional flow model, related mixins, as well as the examples provided by @OmarDuran and @mikeljordan...

## Proposed changes Extending the compositional subpackage to include the compiled, unified flash. Includes the Peng-Robinson EoS, its Soereide extension, and some numerical methods (also compiled) required for the flash....

`SolutionStrategy.after_nonlinear_failure` saves time step data causing weird visualization

4

The base solution strategy at line 477 calls `self.save_data_time_step()` after a time step failes to converge. If the time manager then goes back in time and reduces `dt`, and converges,...

Revisit signature of model methods representing terms in PDEs

3

There are inconsistencies in the signature of respective methods, mostly regarding the usage of `list[pp.Grid]`, `pp.SubdomainOrBoundaries` etc. [See this comment for example.](https://github.com/pmgbergen/porepy/pull/1252#discussion_r1828920325) **Fix**: 1. Go through `models/*.py` and check the...

Revisit module `ad._ad_utils`: Import, availability, typing

1

The *private* module `_ad_utils` is actually used in ~7 files outside of `pp.ad.`. Also, the way it is imported and some of it's functions are made available in top level...