Viktor Larsson

Results 45 comments of Viktor Larsson

It is only a degeneracy in the solver and not inherent to the problem itself, so it is still solvable. I think there are three reasonable options to fix this;...

> @vlarsson I recall that you were interested in investigating the issue about p4pf. Did you have time to do that? I should finally have some time to look into...

> For example, on the cornell arts quad dataset, I get the following with p4pf: ![image](https://private-user-images.githubusercontent.com/134307/309333877-3fab2e7f-f33a-4fd4-9169-5c18efc27dfa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwMzg0NzQsIm5iZiI6MTcyMTAzODE3NCwicGF0aCI6Ii8xMzQzMDcvMzA5MzMzODc3LTNmYWIyZTdmLWYzM2EtNGZkNC05MTY5LTVjMThlZmMyN2RmYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNVQxMDA5MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMTI1YWExOTYxMTE3OTQzOTcxZTg4ZjgxZTlhN2JhYjQwYjhmMWE1ODg5YzkwZDE3NWVjY2RlZDg3M2JhN2NkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VV4ddiXWPgJnf4aAN_NJKysUlHt3z5bYYLesOaN4lik) versus the following for colmap's sampling based approach: ![image](https://private-user-images.githubusercontent.com/134307/309334373-8cdff46d-e62c-4da5-b064-a7fb7c2bc795.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwMzg0NzQsIm5iZiI6MTcyMTAzODE3NCwicGF0aCI6Ii8xMzQzMDcvMzA5MzM0MzczLThjZGZmNDZkLWU2MmMtNGRhNS1iMDY0LWE3ZmI3YzJiYzc5NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNVQxMDA5MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03OTkxNTk3YjAyZDkxM2ExODAzMjBkMGFmOWEwODlhNzAxZDQzZGFlZGVkZWNjNjA0MGIwOWFjYzlkMDFkN2JjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.1bmWnAYqHICH0zfn0KXsdW3PKwynUIbzFWSe5l0OmQg) > > It's not that...

I've done some initial testing. I ran the reconstruction of ArtsQuad (with the main branch version) and dumped all of the correspondences from the registration where estimate_focal_length was set. I...

The reconstruction with the poselib estimator looked okay, however the vanilla colmap reconstruction I got had larger artifacts compared to the result you posted above. I wonder if this scene...

I will have a look at this next week after the 3DV camera ready deadline. So this should upload to pypi when we make new releases? or I am not...

For integrating https://github.com/vlarsson/posebench as a regression test, maybe we should select a smaller subset of the datasets to run. As I understand it, we would need to download the data...

I think I would rather have it as a separate repository. But I guess it should be possible to just clone it in the actions?

Hi, Unfortunately I cannot reproduce this bug. It seems to work both on my M1 laptop, and my regular desktop. Are you building from the master branch? Also, side note:...

Thanks for the update @v-pnk ! I had other issues with segfaulting which were resolved by bumping the pybind11 to the most recent commit. If you still have the setup...