Vlad Filippov

Results 150 comments of Vlad Filippov

> This is boring. :angry: Please keep the comments relevant to the issue, thanks

@madarche i think this was fixed in https://github.com/mozilla/node-convict/pull/269 ?

this version still uses the old way to login right? I don't think device registration will solve the problem here. migrating to the OAuth login will fix this a bit,...

This also works: ```js // IndexedDB hackery begins Object.setPrototypeOf = Object.setPrototypeOf || function(obj, proto) { obj.__proto__ = proto; return obj; } // Make indexeddbshim happy with React Native's environment if...

@brettz9 doing this: ``` const setGlobalVars = require('indexeddbshim'); setGlobalVars({ win: SQLite }, { checkOrigin: false }); ``` ![image](https://user-images.githubusercontent.com/128755/38517396-e02bbad4-3c07-11e8-9324-65659c3a1580.png) Am I missing something?

Doing a log like this: ``` console.log('setGlobalVars', require('indexeddbshim')); ``` produces: ``` 04-09 19:13:36.335 4379 4784 I ReactNativeJS: 'setGlobalVars', {} ``` so the `setGlobalVars` is not exported it seems

@brettz9 the loading via `/src/setGlobalVars` doesn't work. With `import setGlobalVars from 'indexeddbshim';` I get this: The way `import` statements are loaded, it seems that even having ``` if (global.window.navigator.userAgent ===...

> While we can do it ourselves, it still means that we'll need to add another native dependency. So it's unclear what's the best solution here. > Any thoughts/suggestions are...

@addyosmani would be happy to help, let me know.

Well this is wacky, do we need to pull request to those libs or what is exactly happening here?