Build failing on Android

[desktp]

Hello,

Building for Android is failing in a fresh project with the following message:

:react-native-oauth:compileReleaseJavaWithJavac
:react-native-oauth:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/home/desk/dev/gistreader/node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerPackage.java:39: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /home/desk/dev/gistreader/node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
:react-native-oauth:compileReleaseJavaWithJavac FAILED

Commenting the @Override in node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerPackage.java createJSModules method makes the build succeed:

// @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }

Versions: react-native: 0.48.1 react-native-oauth: ^2.2.0

[amorenew]

As I remeber createJSModules is not required in new react native. check react native issues with keyword "createJSModules"

[marcusvbp]

same problem here

"react": "16.0.0-alpha.12",
"react-native": "0.48.3",
"react-native-oauth": "^2.2.0"

[amorenew]

@marcusvbp the library is good but if your needs to use a native facebook app or twitter you need to use several other libraries the library is using webview not the installed apps

[marcusvbp]

@amorenew hi,

I need to implement Google and Facebook authentication . What libs you suggest?

[amorenew]

@marcusvbp As I tried and did a great effort here it is: Facebook: https://github.com/facebook/react-native-fbsdk Twitter: https://github.com/GoldenOwlAsia/react-native-twitter-signin Google: https://github.com/devfd/react-native-google-signin

[minhnhatspk]

the same problem ~~

[mourice]

#https://github.com/react-native-community/react-native-blur/pull/226

[kodie]

Ran into this issue as well. Commenting out the @Override line worked.

[Jakerevans]

Commenting out the @Override line worked for me as well.

[vladikoff]

Well this is wacky, do we need to pull request to those libs or what is exactly happening here?

[shai93]

"react-native": "^0.55.4", didn't work evern after removin @override from RNGoogleSigninPackage.java

Error: Task :react-native-google-signin:compileDebugJavaWithJavac FAILED

android/src/main/java/co/apptailor/googlesignin/RNGoogleSigninPackage.java:25: error: method does not override or implement a method from a supertype @Override ^ 1 error