grunt-usemin icon indicating copy to clipboard operation
grunt-usemin copied to clipboard

Help with maintainance

Open addyosmani opened this issue 10 years ago • 35 comments

If you heavily use or have used grunt-usemin, we would like to ask if you might be interested in helping us maintain this task. As you can probably tell by the PR queue and questions about the project, it's used by many but needs active weekly review of threads and code we might like to land back to the project.

The rest of the Yeoman team are currently focusing on generators, docs and our next version of the project so any help at all would be hugely appreciated.

addyosmani avatar Mar 09 '14 11:03 addyosmani

cc @cbas @halkeye @eskimoblood @akinofftz @tekay @Gamaroff

addyosmani avatar Mar 09 '14 11:03 addyosmani

Yes, sorry for that :( Last months have been quite packed both in professional and personal world ... Will try to merge some in the following days ;)

sleeper avatar Mar 10 '14 13:03 sleeper

I'll see what I can contribute, but I don't really use this module enough to feel like I could help with maintenance. I'll totally continue to submit PRs though.

halkeye avatar Mar 10 '14 16:03 halkeye

Well, the project I've used usemin has been finished and I went to something new, but if there are bugs, I can look what I can do.

akinofftz avatar Mar 11 '14 05:03 akinofftz

Thank you!

addyosmani avatar Mar 12 '14 17:03 addyosmani

We've landed some necessary fixes to grunt-usemin and I've tagged the first release of it we've had in 6 months. Tests are passing but any help you can offer with trying out the latest build would be very useful.

addyosmani avatar Mar 15 '14 13:03 addyosmani

Just wanted to add that we're still looking for help managing this repo. Triaging issues, reviewing PRs, fixing things. Any help welcome :)

sindresorhus avatar Jun 23 '14 16:06 sindresorhus

@sindresorhus I use usemin a lot. I will take a look at some issues to see if I can help. But no promises :/

stephanebachelier avatar Jun 30 '14 10:06 stephanebachelier

I would really love to do this, but I don't have enough spare time for that. Will try to help with further pull requests :/

donaldpipowitch avatar Jul 07 '14 05:07 donaldpipowitch

@addyosmani would be happy to help, let me know.

vladikoff avatar Jul 19 '14 20:07 vladikoff

@stephanebachelier @donaldpipowitch @vladikoff Added you to the repo. Feel free to commit, triage issues and review/merge PRs. No pressure though :)

sindresorhus avatar Jul 19 '14 21:07 sindresorhus

Huge thanks to anyone who has offered their help. Usemin gets used quite a lot and unfortunately, we don't have as much time as we would like to maintain it. If you'd like to help with the list of tasks Sindre mentioned above we'd <3 it. Let us know if you need anything when it comes to tagging/pushing new releases.

addyosmani avatar Jul 24 '14 14:07 addyosmani

@addyosmani I've read through some of it. I'll take some time to help with some issues.

Usemin is the central piece of my workflow :)

stephanebachelier avatar Jul 24 '14 21:07 stephanebachelier

Will try to help with some issues. Let me go through the Issue list. Any priorities ?

sudevkk avatar Aug 05 '14 09:08 sudevkk

@sudevkk Reviewing PRs has priority. Other than that. Go nuts :)

sindresorhus avatar Aug 05 '14 09:08 sindresorhus

If anyone has any questions or is hesitant about closing an issue, landing a PR or any other questions ping @sindresorhus or me or any Yeoman core member and we will step in and provide direction. Thanks for volunteering

eddiemonge avatar Aug 05 '14 16:08 eddiemonge

I should have some free time to take a look and help where I can.

jamesscholeyweb avatar Sep 01 '14 18:09 jamesscholeyweb

yes. thank you.

AliMD avatar Oct 09 '14 11:10 AliMD

I'm def. interested in trying to help out, btw. Maintaining seems a little much, but helping, for sure.

arthurvr avatar Feb 19 '15 19:02 arthurvr

:+1: if I can help to review some PR or fix some issues.

jfroffice avatar May 06 '15 06:05 jfroffice

I'm happy to take on as maintainer.

shamoons avatar Mar 18 '16 19:03 shamoons

That would be great! Lots of pull requests are waiting review :)

karensg avatar Mar 20 '16 14:03 karensg

Would love to take on as another maintainer.

nodox avatar Mar 22 '16 20:03 nodox

@addyosmani @sindresorhus, some people seems to be keen on maintaing this project :)

ptitgraig avatar Mar 23 '16 10:03 ptitgraig

@shamoons @karensg @nodox @ptitgraig Thanks for stepping up. You're now collaborators on this repo :)

The guidelines are simple. Be kind to everyone. Larger changes should come in a pull request. Smaller ones can be committed directly. Pull requests should have at least one :+1: from another collaborator before being merged. Follow the existing code style and ensure npm test passes before pushing a commit. You can use branches in this repo, but clean them up afterwards. Bugs fixes and new features should come with tests. We prefer a clean commit history, so when merging a pull request, either ask the contributor to squash their commits or do it for them manually.

Also keep in mind that the goal of this project is simplicity. That means solving a problem for the 90% with the least amount of options.

The next step and biggest priority is to land @stephanebachelier's dev branch which resolves https://github.com/yeoman/grunt-usemin/issues/244.

sindresorhus avatar Mar 31 '16 07:03 sindresorhus

Or make this a thin wrapper around useref and combine the efforts with @jonkemp to reduce duplication

eddiemonge avatar Mar 31 '16 15:03 eddiemonge

What needs to happen before @stephanebachelier dev branch can be merged? Are we missing tests? @sindresorhus

nodox avatar Apr 07 '16 20:04 nodox

@nodox I don't know. You'll have to ask him.

sindresorhus avatar Apr 07 '16 20:04 sindresorhus

Someone just needs to go through it and make sure it works and merges cleanly

eddiemonge avatar Apr 07 '16 21:04 eddiemonge

@sindresorhus @eddiemonge I'm back in the place. For the dev branch I had asked if anybody could tested it but I don't know about anyone apart from me. I will take a look again at the dev branch. It should still works.

Is there some forum / place to discuss about what to do ? I created the gitter yeoman/grunt-usemin channel last year but there is not so much activity :) Have you got another channel ?

stephanebachelier avatar Apr 12 '16 12:04 stephanebachelier