Vítor Galvão

Results 115 comments of Vítor Galvão

There was a bug in the script and it collected way more than it was supposed to. It was a coincidence that all the ones I checked didn’t have a...

You mean the ML will be able to add all missing zaps?

That’s great. You can outright close the issue when that’s done, then.

Thank you all for the updates and the comments. To clarify, in case you ever check the list and don’t see any boxes ticked, that’s because I semi-regularly regenerate the...

> The only thing that bugs me is the `version.after_comma.before_comma` pattern that could emerge. I feel that’s quite a pain to write and read. Agreed, though not that much worse...

Another reason why `parts` or `comma_parts` is superior to just getting rid of `colon`: `after_comma.after_comma` is weird. Even with one `after_comma`, it’s not obvious if that refers to the first...

> how about using either `-` or `_` as a replacement for Those are commonly used in versions, so it blurs the line between what’s a divider or not. >...

So we have a record, pointing out [a new place in the core that’s introducing `:`](https://github.com/Homebrew/brew/pull/10376/files#r562759754).

@Homebrew/cask Can we get a quick vote on if we should do this (👍) or close (👎)? And if so, should we use `comma_parts`, `parts`, or `csv`? I’m fine with...

> This will require (likely) another round of batch changes Not necessarily. Making it not mandatory ensures we can add them as appropriate. A bit like `auto_updates`: it’s there, but...