Martijn Visser

Results 516 comments of Martijn Visser

Yeah something like h5netcdf would be great, though probably it would be less work to just call HDF5 APIs directly to make valid NetCDF for our use case only, as...

What is the way forward here? Switch to Moshi as suggested in https://github.com/Roger-luo/Expronicon.jl/issues/77#issuecomment-2285035003?

This looks nice! Do you have any benchmark numbers that compare these three options, linear, stepwise hard, stepwise smooth?

As discussed today, we'll go with block interpolation with 0 smoothing as a default. This PR needs to be updated to reflect that.

I think `DiscreteControl / condition` would make most sense. That also is already optionally time-dependent via the `time` column. We could add an optional `interval` column. We could for now...

Would allowing decreasing Q with increasing h (#2045) create issues for this?

Putting this back in draft for now. @SouthEndMusic indicated he didn't measure a performance gain from this. Though I can also imagine this only hits particular models, or that there...

It is intended that we can have control switch between `Ribasim.allocation` or other control states. An example is a reservoir that can release water based on downstream demand, but then...

Also revert this test skip: 15abb72bf740757d7ca35a80a896988307e8329c And these examples: dfc2af16e1f222eae04f5b78f760c9e03f862838 Revert this test removal: 14da9b2bbcf64a964ca229a6a2297405b7167966 And this regression test removal: d4fdfebdc070b03b9136b6d1ffb5e480777693bd

I didn't go over all commits referenced in this issue, but notable https://github.com/Deltares/Ribasim/commit/dfc2af16e1f222eae04f5b78f760c9e03f862838 is not yet reverted or added back in some way to the examples. So I'm reopening, though...