Ribasim icon indicating copy to clipboard operation
Ribasim copied to clipboard

Published 20 hours ago • verified publisher icon Deltares

Run all test models with allocation again in CI

Open SouthEndMusic opened this issue 5 months ago • 5 comments

In https://github.com/Deltares/Ribasim/pull/2266 tesmodelrun.jl was modified to skip test models using allocation. This should be reverted once the new allocation code is stable enough.

SouthEndMusic avatar Jun 18 '25 08:06 SouthEndMusic

Similarly, https://github.com/Deltares/Ribasim/pull/2396 should be reverted

SouthEndMusic avatar Jun 19 '25 08:06 SouthEndMusic

And https://github.com/Deltares/Ribasim/pull/2407/commits/20eb973af739cd3f335ca49f7929e84a949d6bab should be reverted

SouthEndMusic avatar Jun 30 '25 08:06 SouthEndMusic

The test Allocation example model looks like it's also covered by run_models_test

SouthEndMusic avatar Jul 02 '25 13:07 SouthEndMusic

Also revert this test skip: 15abb72bf740757d7ca35a80a896988307e8329c And these examples: dfc2af16e1f222eae04f5b78f760c9e03f862838 Revert this test removal: 14da9b2bbcf64a964ca229a6a2297405b7167966 And this regression test removal: d4fdfebdc070b03b9136b6d1ffb5e480777693bd

visr avatar Jul 17 '25 09:07 visr

I didn't go over all commits referenced in this issue, but notable https://github.com/Deltares/Ribasim/commit/dfc2af16e1f222eae04f5b78f760c9e03f862838 is not yet reverted or added back in some way to the examples. So I'm reopening, though feel free to close if you have other ideas on how to demonstrate to users how they can use allocation.

visr avatar Oct 10 '25 11:10 visr