Martijn Visser
Martijn Visser
Hmm good point about locking access to share resources. And you are right that these evaled functions don't include the optional context argument, it would be good to add them....
Great that this is possible with one line. What do you think about simply documenting that users need to run this line if they want to plot the geometries with...
> LibGEOS can't take a dependency on GeoInterfaceMakie.jl? That was @jw3126's original proposal in #142. As mentioned there the biggest dependency it woul pull in would be GeometryBasics. That seemed...
@jw3126 I see you've set up https://github.com/jw3126/LibGEOSMakie.jl, which is pending registration. Shall we close this PR then for now? If we want we can move it in the subdirectory of...
No I'm aware, that's why I posted https://github.com/JuliaGeo/LibGEOS.jl/pull/144#issuecomment-1311501323. It's mainly GeometryBasics. Though now that LibGEOSMakie exists, perhaps that is fine.
I'll close this since https://github.com/jw3126/LibGEOSMakie.jl/ is registered and mentioned in the readme here: https://github.com/JuliaGeo/LibGEOS.jl#ecosystem In the future we can also consider using extension packages that are part of julia 1.9...
I was confused as well about these two functions. Have you read https://github.com/JuliaGeo/GeoInterface.jl/pull/66? I think the main takeaway is that it should be `Base.convert`, although that doesn't seem like a...
@evetion I guess that means we should add the export back? or should it stay?
Thanks for your thoughts. > Can we make any definitive statements to distill/summarize this PR? I think all 3 points are mostly valid currently, but not 100%. There are still...
Ok, from my side this is good to go. @yeesian do you mind having another look? I added an upgrade guide to the top post, and still removed `geos_operations.jl`, and...