LibGEOS.jl icon indicating copy to clipboard operation
LibGEOS.jl copied to clipboard

Differentiate between `Base.convert` and `GeoInterface.convert`

Open jw3126 opened this issue 3 years ago • 2 comments

It is my understanding, that at some point in the past Base.convert === GeoInterface.convert. However, these are two different functions nowadays and we overload Base.convert where GeoInterface.convert would be the correct protocol in some cases.

jw3126 avatar Nov 18 '22 06:11 jw3126

I was confused as well about these two functions. Have you read https://github.com/JuliaGeo/GeoInterface.jl/pull/66? I think the main takeaway is that it should be Base.convert, although that doesn't seem like a solution that can cover all cases as I mention in this post, so I think it needs more work.

visr avatar Nov 19 '22 10:11 visr

Oh interesting I was not aware, thanks!

jw3126 avatar Nov 19 '22 12:11 jw3126