virtul
virtul
@grojo-ea @james-moran-ea Can you please review this PR?
> Sorry for the delay, this looks good to me. I'd be happy to merge it but I don't see you in the list of users who've signed our CLA,...
I don't have time right now to triangulate this issue further. But essentially key here is return value of function. So it's should be either: ``` // assume hereo that...
Nvm, this did not fix it. WIP, please don't merge (yet)
Okay. Now fixed. Code like ``` eastl::list foo, bar; foo.swap(bar) ``` now compiles (but require `EASTL_NAME_ENABLED` being off)
@rparolin @grojo-ea @jhopkins-ea Any chance onto reviewing and merging this (and (`*`)) commits? (`*`) PS: https://github.com/electronicarts/EASTL/issues?q=is%3Apr+is%3Aopen+author%3Avirt00l
Example of includes when building in clang-cl mode: ``` Note: including file: ...\EASTL/algorithm.h Note: including file: ...\EASTL/internal/copy_help.h Note: including file: ...\EASTL/iterator.h Note: including file: ...\EASTL/initializer_list.h Note: including file: d:\...\include\stddef.h Note:...
Im pretty sure that's intentionaly for perfomance sake `strlen("foo", NULL)` would also segfault (I assuming for the same reason)