electronicarts
Protect string comparisons against segfaults
This intends to resolve #546.
Comparing string objects to nullptr is not prevented by the implementation. Therefore, it should check before starting the actual comparison - which currently leads to a segfault due to the unprotected use of CharStrlen. Given that CharStrlen fulfills the standard specification of showing UB when called like that, the issue should be fixed on the calling site.
The first commit introduces minimal test cases for the global equality operators for basic_string, the second the (quite small) fix.
Im pretty sure that's intentionaly for perfomance sake
strlen("foo", NULL) would also segfault (I assuming for the same reason)
I do acknowledge that strlen (or the EASTL variant of it, CharStrlen) may segfault, as this is allowed by the specification. What is far less obvious to me is the described use of comparison operators. The current behavior is especially brittle in template contexts.
Do you have an indication on performance impact in this use case? And maybe a recommendation on an alternative solution?