vinayak hegde
vinayak hegde
Hello @risdenk , Please accept my apologies for arriving late. I was wondering if anything else needs my attention, as I believe I have completed all the necessary modifications.
> LGTM, but let's clarify the failure of TestPointInTimeRestore before moving further. These tests are passing on my local system, so I’m not sure why they’re failing here. I did...
> LGTM overall. I just have a couple of minor comments. > > Also, just curious - What happens when a WAL that has bogus/garbage values is read? Is an...
> LGTM. > > However, do we need a new config for this? Should we not skip empty WALs by default? I'm not entirely sure. Skipping empty WALs by default...
@ankitsol You need to run `mvn spotless:apply` to fix code style issues.
@NihalJain @DieterDP-ng can you guys take a look into this?
@DieterDP-ng yeah, I checked that. it is not present in 2.x branch. I will update the content with this.
> > 6. Does it support pause (disable_peer)? > > This is a very good question. Given that it's a standard replication endpoint, I would say sure, why not. This...
> > > 3. If we have normal replication enabled (a normal replication peer), will all CFs with REPLICATION_SCOPE = 1 also be targeted for this PITR? > > >...
>Can you elaborate further how this peer is defined? https://github.com/apache/hbase/blob/6aa212f5abe3b1556740c3e7e80a4761d21a1c15/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/FullTableBackupClient.java#L269 this contains the whole logic. > Ok, so we can only do actually PITR within that window period. Can you...