solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API

Open vinayakphegde opened this issue 2 years ago • 1 comments

https://issues.apache.org/jira/browse/SOLR-16677

Description

Updated the Solr to use IndexReader.storedFields() and IndexReader.termVectors() instead of Deprecated IndexReader.document() and IndexReader.getTermVector().

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the main branch.
  • [x] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

vinayakphegde avatar Apr 11 '23 06:04 vinayakphegde

Hello @risdenk , Please accept my apologies for arriving late. I was wondering if anything else needs my attention, as I believe I have completed all the necessary modifications.

vinayakphegde avatar Apr 27 '23 09:04 vinayakphegde

proposed CHANGES.txt:

SOLR-16677: Update Solr to use new Lucene 9.5 storedFields() API. This removes the use of ThreadLocal for
stored field state, reducing heap usage especially for high-core-count, high-field-count, high-thread-count
cases (Vinayak Hegde, Christine Poerschke, Kevin Risden, David Smiley, Michael Gibney)

@vinayakphegde if you'd like to be credited some other way, please let me know; and thanks for your work getting the ball rolling on this!

magibney avatar Jun 24 '24 18:06 magibney

I plan to merge this tomorrow, pending feedback.

magibney avatar Jun 25 '24 20:06 magibney