Vijendar Mukunda
Vijendar Mukunda
> I think sdw_intel_scan_controller() function can be made as generic . Only delta we see max no of links. If we handle it correctly, then I think we can use...
> > > I think sdw_intel_scan_controller() function can be made as generic . Only delta we see max no of links. If we handle it correctly, then I think we...
> @vijendarmukunda the preference from Intel would be to add a comment > > ``` > /* This file incorporates work covered by the following copyright notice: Copyright (c) 2020...
> @vijendarmukunda the preference from Intel would be to add a comment > > ``` > /* This file incorporates work covered by the following copyright notice: Copyright (c) 2020...
Changes Since V1: 1) Moved all SoundWire codec helper functions to sdw_utils folder. 2) Updated copyright statement 3) Moved codec_info_list structure and its corresponding helper functions. 4) Moved common Soundwire...
observing merge conflicts will rebase and log the changes in new pr.
> In sdw_slave_read_prop() function, below condition is not addressed. nval = hweight32(prop->source_ports); prop->src_dpn_prop = devm_kcalloc(&slave->dev, nval, sizeof(*prop->src_dpn_prop), GFP_KERNEL); if (!prop->src_dpn_prop) return -ENOMEM; > > Second condition check: > > prop->sink_dpn_prop...
> > In sdw_master_read_amd_prop() function , for below check , fwnode_handle_put(link) addition is missing. > > link = device_get_named_child_node(bus->dev, name); if (!link) { dev_err(bus->dev, "Manager node %s not found\n", name);...
> sdw_slave_read_dpn Correct. Port references are released in sdw_slave_read_dpn (). No need to add put for these cases.