linux icon indicating copy to clipboard operation
linux copied to clipboard

AMD SoundWire SOF generic driver changes for ACP 6.3 platform

Open vijendarmukunda opened this issue 1 year ago • 3 comments

This patch series is revised version of https://github.com/thesofproject/linux/pull/4817.

Compared to previous patch series, Below are the major changes.

  • Define common Soundwire machine driver soc ops
  • Move common Soundwire helper functions
  • Move Soundwire codec helper functions

Not able to move all codec helper functions(like jack) as they are dependent on machine driver private data structures which will be different for Intel & AMD platforms. If partly codec helper functions made common, i think it's not good a choice to make few of codec helper functions as generic and few codec helper functions as platform specific.

In next series, will work on DAI parsing logic.

I do have still doubts on copyrights usage as I have moved codec helper files from intel/boards -> sdw_utils folder. Please help to provide suggestion on correct copyright usage.

vijendarmukunda avatar Apr 10 '24 05:04 vijendarmukunda

@vijendarmukunda the preference from Intel would be to add a comment

/* This file incorporates work covered by the following copyright notice: Copyright (c) 2020 Intel Corporation */

below the new AMD copyright notice. (the year may vary depending on files)

plbossart avatar Apr 10 '24 23:04 plbossart

@vijendarmukunda the preference from Intel would be to add a comment

/* This file incorporates work covered by the following copyright notice: Copyright (c) 2020 Intel Corporation */

below the new AMD copyright notice. (the year may vary depending on files)

will update the copyright

vijendarmukunda avatar Apr 11 '24 13:04 vijendarmukunda

@vijendarmukunda the preference from Intel would be to add a comment

/* This file incorporates work covered by the following copyright notice: Copyright (c) 2020 Intel Corporation */

below the new AMD copyright notice. (the year may vary depending on files)

will update the copyright.

vijendarmukunda avatar Apr 12 '24 05:04 vijendarmukunda

Changes Since V1:

  1. Moved all SoundWire codec helper functions to sdw_utils folder.
  2. Updated copyright statement
  3. Moved codec_info_list structure and its corresponding helper functions.
  4. Moved common Soundwire codec helper functions.
  5. Moved Machine driver dai link helper functions.
  6. Refactored late probe() function
  7. Add pci revision id field in mach_params structure and used it in amd sof driver stack.
  8. Renamed all common functions with _sdw tag.
  9. Rename structure names and macros to make it generic.

vijendarmukunda avatar Apr 25 '24 12:04 vijendarmukunda

observing merge conflicts will rebase and log the changes in new pr.

vijendarmukunda avatar Apr 25 '24 12:04 vijendarmukunda