Vijay comments

Results 36 comments of


                                            Vijay

Fix #20594 : Feature - 'consul tls cert renew' command

Hi @david-yu, Kindly review this PR.

Fix #20594 : Feature - 'consul tls cert renew' command

Did one more round of self review, thought of adding an improvement - Ideally for cert renew command the args like domain, dc, server/client/cli,.. should not be required to be...

Fix #20594 : Feature - 'consul tls cert renew' command

Reminding to review this PR

Consul tls command should be able to renew

Hi @reskin89, We have similar issue to alert about TLS expiry in UI https://github.com/hashicorp/consul/issues/19358 and the PR for that https://github.com/hashicorp/consul/pull/19427 Its good suggestion to have renew command as well, looking...

fix #20409 - Check definitions not reflected in output from agent/health/service/id/:service-id

As an update, even after populating the HealthCheckDefinition, the expected values are not shown in api output. Apart from the changes done so far in func agentHealthService, there needs some...

fix #20409 - Check definitions not reflected in output from agent/health/service/id/:service-id

The fix is almost done! For some reason the "Definition" field was left out while creating "check" before adding to the local "state" in https://github.com/hashicorp/consul/blob/c82b78b088c6e99a511018ed4f6ac2f1fb364420/agent/agent.go#L2626 Added three fields and verified,...