consul
consul copied to clipboard
hashicorp
fix #20409 - Check definitions not reflected in output from agent/health/service/id/:service-id
Fixes #20409
Testing & Reproduction steps
Refer #20409
PR Checklist
- [x] updated test coverage
- [ ] external facing docs updated
- [ ] appropriate backport labels added
- [x] not a security concern
As an update, even after populating the HealthCheckDefinition, the expected values are not shown in api output. Apart from the changes done so far in func agentHealthService, there needs some more update to fix the issue, so checking the service registration code. Will update once the fix is complete.
The fix is almost done! For some reason the "Definition" field was left out while creating "check" before adding to the local "state" in https://github.com/hashicorp/consul/blob/c82b78b088c6e99a511018ed4f6ac2f1fb364420/agent/agent.go#L2626 Added three fields and verified, its working as expected now!. Need to add all other fields (like HTTP, TCP,...). Will check the logic thoroughly again and update.
Hi @jkirschner-hashicorp / @huikang / @david-yu , Kindly review this PR.
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.