Julien Viet

Results 921 comments of Julien Viet

is that expected to have a client sending more than one `CONNECT` ?

I think it would be better to have instead a boolean set to `true` when client connected so we don't handle the connect procedure twice. also the heartbeat code seems...

@anatoliyck agreed, was just wondering

@pconway11 there is now `HttpClientRequest.connection()`, how about adding `closed()` boolean here ?

can you provide a reproducer project with Maven so we can reproduce easily ? thanks

I think that the main issue is the event bus bridge only knows `ReplyException` and cannot know `ServiceException` since it's a subclass of `ServiceException`. So for this to work, some...

So for this we need to have - `ReplyException` define a `toJson()` method that returns the `JsonObject` - have the event bus bridges (SockJS and TCP) use it - override...

I believe it's good contribution, however we should resolve this in vertx 3.x and not in vertx 4 that will advocate to use `CompletionStage`.

we should avoid using primitive arrays with Tuple instead of trying to use a different type than what the Tuple expects (or the default methods of Tuple should be reimplemented...