Victor Berchet
Victor Berchet
@DavisChappins my understanding is that skylines is not really interested in getting data from any other sources - to be clear I am not part of the project. However there...
1) XCSoar is only one possible client (FlySkyHigh, Skylines Tracker, ...), 2) Chicken and egg problem.
Hum... I'm not sure what's wrong with black here. I ran it on my code :( Would be nice to have some more feedback in the logs. I'll look into...
Other changes in this PR: - Add the `--diff` flag for black (lint test) so that error logs are actionable (different versions of black lead to different formatting), - Format...
Hey @Turbo87 is there anything missing for this to be reviewed, merged and deployed ? No rush but please let me know if more work is expected from me here....
**EDIT: The actual issue in protobuf-js, while this should also resolve the issue it probably better to fix protobufjs (see below for details)** I have update `encodeValue` to read like:...
I have done some digging into this bug: Calling `datastore.save(...)` ends up @grpc/proto-loader [`createSerializer`](https://github.com/grpc/grpc-node/blob/master/packages/proto-loader/src/index.ts#L167-L172) ```typescript function createSerializer(cls: Protobuf.Type): Serialize { return function serialize(arg: object): Buffer { const message = cls.fromObject(arg);...
It seems like this might be related to: - https://github.com/protobufjs/protobuf.js/pull/1500 - https://github.com/protobufjs/protobuf.js/issues/885
Patching protobufjs/protobuf.js#1500 did resolve the issue. I'll try to move that PR forward and then propagate the fix through the dependencies.