Victor Berchet

Results 232 comments of Victor Berchet

See https://github.com/protobufjs/protobuf.js/pull/1514#pullrequestreview-545366600, the proper fix in protobuf.js should be in v7 The current nodejs-datastore code uses [a workaround](https://github.com/googleapis/nodejs-datastore/pull/767/files#diff-943283b35b29d42b616883e0c704cd3a6a1b6e15872d7708c4f04f1caf330524R635) that could be removed once protobuf.js is fixed - that v7 is...

It would be nice to create a migration path for DB created before inference is removed. In such DB there could be a mix of integer/float for the same property...

The ideal solution is that `.filter('integer_column', '>', value)` works whatever the (numerical) value. I mean `10 > 5.123 == true` is something everybody expects to work, whatever the language/API. Edit:...

1) Again everybody expects `10 > 5.123 == true`. The opposite is **very** misleading. 2) Thoughts: > So, if we're given a float of `123.456`, we would have to lose...

Thanks for checking other clients. > I don't think the client can do that without side effects. May be it should be done server side then ? In the meantime...

The concern is expressed in my former message is real. Let's init a table with [0...9] / 2: ```typescript for (let value = 0; value < 10; value++) { const...

@crwilcox how is this not a bug. JS has `number`s not `int` or `float`. If you look at my example I save some `number`s and because some happen to be...

Hey @crwilcox, I would add the following the client side options (1-3 below refer to the options in your message). 1) I am not exactly what you mean here. If...

Reading the docs, it looks like this behavior [is actually documented](https://cloud.google.com/datastore/docs/concepts/entities#value_type_ordering) TL;DR Integers are sorted before FPs. I think this makes working with FP values in JS (and probably other...

Yes so the whole problem is that in JS `Number.IsInteger(4.0) === true`. This basically makes the main API of datastore unusable for float numbers as you can not rule out...